Documentation build overview

📚 cpython-previews | 🛠️ Build #34241299 | 📁 Comparing 864063d against main (f54fd2a)

  🔍 Preview build  

My comments on the previous PR might or might not apply. I have not interacted with doctests since then.

I saw your previous comments @terryjreedy , and I don't think that they apply here.

• gh-111735: Fix turtle.rst doctests when tkinter is not present #111736 (comment): I don't see a reason to add support for vanilla doctest when Sphinx's doctest does the job here.
• gh-111735: Fix turtle.rst doctests when tkinter is not present #111736 (comment): It doesn’t, it's specific to that one directive.
• gh-111735: Fix turtle.rst doctests when tkinter is not present #111736 (comment): It hides the codeblock in the rendered docs, it's only there for testing purposes.

After 859c068 Doc/conf.py:24 sets _tkinter to None after import failure. To detect a future regression in local testing, should we add a CI or buildbot test that patches conf.py to _tkinter = None and then runs Sphinx doctest on turtle.rst?

To detect a future regression in local testing, should we add a CI or buildbot test that patches conf.py to _tkinter = None and then runs Sphinx doctest on turtle.rst?

I think we can leave this to a separate PR. We don't currently have any Buildbots that run any form of docs build, so this would need quite a bit of work in buildmaster-config, as well as someone to sponsor the machine it will run on. Adding it to the CI is also possible. But to be honest, I'm not sure there's a real benefit. Only we (CPython developers) run the doctests, and when we do it's usually with tkinter. I don't think the cost justify protecting against regressions here.

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

GH-156470 is a backport of this pull request to the 3.15 branch.

Sorry, @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker eb089020696e451e64a51534726efa80dcbdc902 3.13

GH-156471 is a backport of this pull request to the 3.14 branch.

GH-156478 is a backport of this pull request to the 3.13 branch.