Repository navigation
gh-153569: Replace tokenizer input readers - #156472
Merged
pablogsal merged 5 commits intoAug 28, 2026
Merged
pablogsal merged 5 commits into
pablogsal merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
pablogsal
requested review from
a team,
AA-Turner,
emmatyping,
ericsnowcurrently,
erlend-aasland,
itamaro and
lysnikolaou
as code owners
August 27, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid of the four separate tokenizer input implementations and replaces them with one reader and decoder pipeline. Files, strings, readline callbacks, and interactive input now share encoding detection, incremental decoding, newline handling, and cleanup, so the duplicated reader state and helpers go away. Complete UTF-8 callback lines skip incremental codec setup, while split and stateful input keeps the decoder state it needs. Interactive input keeps the source it needs without making the other readers retain a second copy.
This is the next part of #153569.