FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-37953:Improve ForwardRef equality check by hongweipeng · Pull Request #15650 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-37953:Improve ForwardRef equality check - #15650

Closed
hongweipeng wants to merge 1 commit into
python:masterfrom
hongweipeng:improve_ForwardRef_equality
ConversationCommits (1)ChecksFiles changed
Closed

bpo-37953:Improve ForwardRef equality check#15650
hongweipeng wants to merge 1 commit into
python:masterfrom
hongweipeng:improve_ForwardRef_equality

Conversation

hongweipeng commented Sep 2, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

hongweipeng mentioned this pull request Sep 2, 2019
Closed

hongweipeng commented Sep 2, 2019

Copy link
Copy Markdown
Contributor Author

This PR can solve the recursion problem incidentally https://bugs.python.org/issue37806. I add some tests for that.

hongweipeng mentioned this pull request Sep 2, 2019
Closed
aeros reviewed Sep 2, 2019
View reviewed changes

aeros left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Based on @ilevkivskyi's comment in the related PR:

Generally, I would propose to keep only one PR open, because currently the discussion is scattered between two PRs.

Let's hold off on moving forward with this one until we reach a clear consensus on what direction this should be going. Also, it looks like the author of #15400 is still interested in working on their PR.

aeros added DO-NOT-MERGE type-feature A feature request or enhancement labels Sep 2, 2019
ilevkivskyi mentioned this pull request Sep 11, 2019
Merged

ilevkivskyi commented Sep 11, 2019

Copy link
Copy Markdown
Member

Closing in favour of the original PR #15400 (see my comment there).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum Awaiting requested review from gvanrossum
ilevkivskyi Awaiting requested review from ilevkivskyi
1 more reviewer
aeros aeros left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL