Repository navigation
[3.14] gh-156635: Fix the exceptions in the xml.dom documentation (GH-156636) - #156638
Merged
serhiy-storchaka merged 1 commit intoAug 30, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…honGH-156636) Node.insertBefore(), Node.removeChild() and Node.replaceChild() raise NotFoundErr, not ValueError. Element.removeAttribute() and Element.removeAttributeNS() raise NotFoundErr if there is no matching attribute, which contradicts the DOM, so this is documented as a deviation in the minidom documentation. (cherry picked from commit 74b944a) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.insertBefore(), Node.removeChild() and Node.replaceChild() raise
NotFoundErr, not ValueError.
Element.removeAttribute() and Element.removeAttributeNS() raise
NotFoundErr if there is no matching attribute, which contradicts the
DOM, so this is documented as a deviation in the minidom documentation.
(cherry picked from commit 74b944a)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com