Repository navigation
gh-54092: Implement writexml() for DocumentFragment in xml.dom.minidom - #156646
Merged
serhiy-storchaka merged 4 commits intoSep 13, 2026
Merged
serhiy-storchaka merged 4 commits into
serhiy-storchaka merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…minidom toxml() and toprettyxml() now work for document fragments. They write the children of the fragment, without adding a level of indentation.
Copy link
Copy Markdown
Documentation build overview82 files changed · + 8 added · ± 73 modified · - 1 deleted + Added
± Modified
- Deleted |
Sorry, something went wrong.
serhiy-storchaka
enabled auto-merge (squash)
September 13, 2026 14:59
…ment-writexml # Conflicts: # Doc/library/xml.dom.minidom.rst # Doc/whatsnew/3.16.rst # Lib/test/test_minidom.py
…' into pythongh-54092-fragment-writexml
johnslavik
pushed a commit
to johnslavik/cpython
that referenced
this pull request
Sep 14, 2026
…minidom (pythonGH-156646) toxml() and toprettyxml() now work for document fragments. They write the children of the fragment, without adding a level of indentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentFragment was the only serializable node type without a writexml() method, so toxml() and toprettyxml() failed with AttributeError for document fragments. It was documented as implemented since GH-12677.
The fragment writes its children at the current indentation, without adding a level of indentation for itself, as it has no tag.