Repository navigation
gh-156665: Validate namespaces in xml.dom.minidom - #156666
Merged
serhiy-storchaka merged 2 commits intoSep 13, 2026
Merged
serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
createElementNS(), createAttributeNS() and setAttributeNS() now raise NamespaceErr for a malformed qualified name, for a prefix with an empty namespace, and for illegal use of the "xml" and "xmlns" prefixes, as required by DOM Level 2 Core. Setting the prefix of an attribute is validated too. Two tests used a wrong namespace URI for xmlns attributes.
Copy link
Copy Markdown
Documentation build overview60 files changed · + 1 added · ± 58 modified · - 1 deleted + Added ± Modified
- Deleted |
Sorry, something went wrong.
johnslavik
pushed a commit
to johnslavik/cpython
that referenced
this pull request
Sep 14, 2026
) createElementNS(), createAttributeNS() and setAttributeNS() now raise NamespaceErr for a malformed qualified name, for a prefix with an empty namespace, and for illegal use of the "xml" and "xmlns" prefixes, as required by DOM Level 2 Core. Setting the prefix of an attribute is validated too. Two tests used a wrong namespace URI for xmlns attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NamespaceErr is now raised by createElementNS(), createAttributeNS(), setAttributeNS() and when setting the prefix of an attribute.
Two existing tests created xmlns:python attributes with "http://www.w3.org" as the namespace URI instead of the XMLNS namespace, and are fixed here.