FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-153740: refine test for _Float16 (check support from libm) by skirpichev · Pull Request #156815 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-153740: refine test for _Float16 (check support from libm) - #156815

Merged
vstinner merged 2 commits into
python:mainfrom
skirpichev:fix-Float16-check/153740
Sep 2, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-153740: refine test for _Float16 (check support from libm)#156815
vstinner merged 2 commits into
python:mainfrom
skirpichev:fix-Float16-check/153740

Conversation

skirpichev commented Sep 2, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

skirpichev self-assigned this Sep 2, 2026
bedevere-app Bot mentioned this pull request Sep 2, 2026
Closed
1 of 6 tasks
skirpichev force-pushed the fix-Float16-check/153740 branch from deebbb7 to 0567678 Compare September 2, 2026 11:07
python deleted a comment from bedevere-bot Sep 2, 2026

skirpichev commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

!buildbot freebsd

bedevere-bot commented Sep 2, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 0567678 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F156815%2Fmerge

The command will test the builders whose names match following regular expression: freebsd

The builders matched are:

  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD16 PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD14 PR

vstinner reviewed Sep 2, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I tested your change manually on FreeBSD: it works as expected.

Please update the comment to explain why you test isinf(). You can do that once the buildbot completes.

Comment thread configure.ac Outdated
int main(void)
{
_Float16 val = 1.0f16;
int test = !isfinite(val) || isinf(val) || isnan(val);

vstinner Sep 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please complete # Check for native half-float type (_Float16). comment to explain why you test these function calls. Something like:

# Check for native half-float type (_Float16).
# Check also for isinf(_Float16): it's not supported on FreeBSD 15.

skirpichev requested a review from vstinner September 2, 2026 12:59
skirpichev removed their assignment Sep 2, 2026
skirpichev marked this pull request as ready for review September 2, 2026 12:59

skirpichev commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

I tested your change manually on FreeBSD: it works as expected.

Yes, failures on buildbots looks unrelated.

Please complete # Check for native half-float type (_Float16). comment to explain why you test these function calls.

I've added inline comments on test. We don't use anything beyond isinf/isnan from the libm, so I think it's fine.

skirpichev commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

!buildbot FreeBSD14

bedevere-bot commented Sep 2, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 8daf2de 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F156815%2Fmerge

The command will test the builders whose names match following regular expression: FreeBSD14

The builders matched are:

  • AMD64 FreeBSD14 PR

vstinner merged commit 2271fbb into python:main Sep 2, 2026
49 checks passed

vstinner commented Sep 2, 2026

Copy link
Copy Markdown
Member

Merged. Thanks for the fix.

The first commit passed on FreeBSD buildbots. Only FreeBSD 15 failed, but on multiprocessing tests which is unrelated.

I tested manually that the updated PR fix building Python on my FreeBSD 15.

skirpichev deleted the fix-Float16-check/153740 branch September 2, 2026 18:45
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Sep 12, 2026
pythongh-153740: Refine test for _Float16: check support from libm (p…
66a0dd9 
…ython#156815)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner Awaiting requested review from vstinner
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
itamaro Awaiting requested review from itamaro itamaro is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL