gh-156865: struct.pack() check for overflows for Zf type by skirpichev · Pull Request #156868 · python/cpython · GitHub

Issue: Overflows happened silently in array.array setters for 'e', 'f' and 'Zf' format types #156865

Co-authored-by: Victor Stinner <vstinner@python.org>

Merged, thanks.

pythongh-156867 : struct.pack() check for overflows for Zf type

b3e8b33

bedevere-app Bot mentioned this pull request Sep 3, 2026

struct.pack() doesn't checks overflows for native 'Zf' format type #156867

Closed

bedevere-app Bot added the awaiting review label Sep 3, 2026

skirpichev requested a review from vstinner September 3, 2026 01:38

skirpichev added needs backport to 3.14 bugs and security fixes 3.15 pre-release feature fixes, bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed 3.15 pre-release feature fixes, bugs and security fixes labels Sep 3, 2026

skirpichev changed the title gh-156867: struct.pack() check for overflows for Zf type gh-156865: struct.pack() check for overflows for Zf type Sep 3, 2026

bedevere-app Bot mentioned this pull request Sep 3, 2026

Overflows happened silently in array.array setters for 'e', 'f' and 'Zf' format types #156865

Closed

skirpichev removed needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 3, 2026

vstinner reviewed Sep 18, 2026

View reviewed changes

Comment thread Modules/_struct.c Outdated

Comment thread Lib/test/test_struct.py Outdated

skirpichev and others added 3 commits September 19, 2026 02:48

Update Lib/test/test_struct.py

9201d77

Co-authored-by: Victor Stinner <vstinner@python.org>

Merge branch 'master' into overflows-in-Zf/156867

33ab0fd

address review: ensure buffer unmodified on overflow

cc09ac8

skirpichev requested a review from vstinner September 19, 2026 00:00

+ fix bp/lp_float_complex + indentation

901201f

vstinner reviewed Sep 23, 2026

View reviewed changes

Comment thread Lib/test/test_struct.py Outdated

Apply suggestion from @vstinner

465944b

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner merged commit 0b447ba into python:main Sep 24, 2026
55 checks passed

bedevere-app Bot removed the awaiting review label Sep 24, 2026

skirpichev deleted the overflows-in-Zf/156867 branch September 24, 2026 08:42

gh-156865: struct.pack() check for overflows for Zf type by skirpichev · Pull Request #156868 · python/cpython · GitHub

Repository navigation

gh-156865: struct.pack() check for overflows for Zf type - #156868

gh-156865: struct.pack() check for overflows for Zf type#156868
vstinner merged 6 commits into
python:mainfrom
skirpichev:overflows-in-Zf/156867

skirpichev commented Sep 3, 2026 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner commented Sep 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gh-156865: struct.pack() check for overflows for Zf type by skirpichev · Pull Request #156868 · python/cpython · GitHub

Repository navigation

gh-156865: struct.pack() check for overflows for Zf type - #156868

gh-156865: struct.pack() check for overflows for Zf type#156868vstinner merged 6 commits intopython:mainpython/cpython:mainfrom skirpichev:overflows-in-Zf/156867skirpichev/cpython:overflows-in-Zf/156867Copy head branch name to clipboard

Conversation

skirpichev commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner commented Sep 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gh-156865: struct.pack() check for overflows for Zf type#156868
vstinner merged 6 commits into
python:mainfrom
skirpichev:overflows-in-Zf/156867

skirpichev commented Sep 3, 2026 •
edited
Loading