Repository navigation
gh-63102: Support custom targets in the pull parser - #156888
Merged
serhiy-storchaka merged 4 commits intoSep 13, 2026
Merged
serhiy-storchaka merged 4 commits into
serhiy-storchaka merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The list of events was collected by the TreeBuilder in the C implementation, so the pull parser only worked with the standard target. The parser itself now collects the events, and reports what the target returns. XMLPullParser and iterparse() get the target parameter, which makes it possible to parse a large document incrementally without building a tree for it. The namespace events no longer need a separate code path: the parser reports the prefix and the uri if the target does not implement start_ns()/end_ns(), as the Python implementation already did.
Copy link
Copy Markdown
Documentation build overview43 files changed · + 1 added · ± 41 modified · - 1 deleted + Added ± Modified
- Deleted |
Sorry, something went wrong.
TypeError is raised in the constructor if the target does not implement start(), end(), comment() or pi() for the corresponding event, in both implementations. The C implementation silently reported nothing and the Python implementation raised AttributeError while parsing.
serhiy-storchaka
enabled auto-merge (squash)
September 13, 2026 10:42
…-target # Conflicts: # Modules/_elementtree.c
This was referenced Sep 13, 2026
johnslavik
pushed a commit
to johnslavik/cpython
that referenced
this pull request
Sep 14, 2026
…56888) The list of events was collected by the TreeBuilder in the C implementation, so the pull parser only worked with the standard target. The parser itself now collects the events, and reports what the target returns. XMLPullParser and iterparse() get the target parameter, which makes it possible to parse a large document incrementally without building a tree for it. The namespace events no longer need a separate code path: the parser reports the prefix and the uri if the target does not implement start_ns()/end_ns(), as the Python implementation already did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the C implementation the list of events was collected by the TreeBuilder, so the pull parser only worked with the standard target. The parser itself now collects the events and reports what the target returns.
XMLPullParser and iterparse() get the target parameter, which makes it possible to parse a large document incrementally without building a tree for it.
The namespace events no longer need a separate code path: the parser reports the prefix and the URI if the target does not implement start_ns() and end_ns(), as the Python implementation already did.