FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-155742: Add tests on the PyMarshal C API by vstinner · Pull Request #156890 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-155742: Add tests on the PyMarshal C API - #156890

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:testcapi_marshal
ConversationCommits (1)ChecksFiles changed
Closed

gh-155742: Add tests on the PyMarshal C API#156890
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:testcapi_marshal

Conversation

vstinner commented Sep 3, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Add Lib/test/test_capi/test_marshal.py and
Modules/_testcapi/marshal.c files.

pythongh-155742: Add tests on the PyMarshal C API
52edfad 
Add Lib/test/test_capi/test_marshal.py and
Modules/_testcapi/marshal.c files.
vstinner requested a review from a team as a code owner September 3, 2026 10:44
bedevere-app Bot mentioned this pull request Sep 3, 2026
Closed

vstinner commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka

vstinner mentioned this pull request Sep 3, 2026
Closed
serhiy-storchaka reviewed Sep 3, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lib/test/test_marshal.py already contains CAPI_TestCase, which tests the same functions with helpers in Modules/_testcapimodule.c -- all except PyMarshal_ReadObjectFromString() and PyMarshal_WriteObjectToString().

vstinner commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Lib/test/test_marshal.py already contains CAPI_TestCase

Oh no, I missed these tests :-( I will try to merge my tests with these ones.

serhiy-storchaka commented Sep 3, 2026

Copy link
Copy Markdown
Member

Look also at #155909.

vstinner commented Sep 13, 2026

Copy link
Copy Markdown
Member Author

I will write a PR to include my added tests to marshal C API tests, but first I wrote PR gh-157417 to move these tests to the new test_capi.test_marshal.

vstinner commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

I merged the new and more complete tests as PR gh-157452. I close this PR.

vstinner closed this Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
itamaro Awaiting requested review from itamaro itamaro is a code owner

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL