Repository navigation
gh-156896: Stop scrubbing tkinker submodules upon idlelib.run import - #156915
terryjreedy merged 1 commit into
Conversation
Sorry, something went wrong.
…mport Instead, invoke the scrubbing within run.main, which is called after the import when starting the IDLE user process. To manually test that scrub_tkinter_submodules is called when proper, start (or restart) Shell, enter `import tkinter; dir(tkinter), and check that that font, messagebox, ttk, and the dialog modules are missing. It is obvious from the code that the function is not otherwise called. To test anyway, continue with `import tkinter.ttk; import idlelib.run; tkinter.ttk` and check for proper output.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
I tried more radical approach -- removing any Tkinter dependency from idlelib.run. But this is complicated due to stackviewer.
Sorry, something went wrong.
|
I hope to further reduce the dependency by further reducing the imports. This is part of the purpose of the util module. |
Sorry, something went wrong.
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
|
Sorry, @terryjreedy, I could not cleanly backport this to 3.15 due to a conflict. cherry_picker e50d23389be07bf702bde74c3cda794c6febb53e 3.15 |
Sorry, something went wrong.
|
Sorry, @terryjreedy, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker e50d23389be07bf702bde74c3cda794c6febb53e 3.14 |
Sorry, something went wrong.
|
Sorry, @terryjreedy, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker e50d23389be07bf702bde74c3cda794c6febb53e 3.13 |
Sorry, something went wrong.
|
The gh-59396 additions in lines 34 to 44 (prior to this patch) were not backported. I will do that later and these backports should then work. |
Sorry, something went wrong.
|
Serhiy, the not-backported changes are your. See dicord DM. |
Sorry, something went wrong.
|
GH-156958 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
|
GH-156959 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
|
GH-156960 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
…import (GH-156915) (#156959) gh-156896: Stop scrubbing tkinter submodules upon idlelib.run import (#156915) Instead, invoke the scrubbing within run.main, which is called after the import when starting the IDLE user process. To manually test that scrub_tkinter_submodules is called when proper, start (or restart) Shell, enter `import tkinter; dir(tkinter), and check that that font, messagebox, ttk, and the dialog modules are missing. It is obvious from the code that the function is not otherwise called. To test anyway, continue with `import tkinter.ttk; import idlelib.run; tkinter.ttk` and check for proper output. (cherry picked from commit e50d233) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
…import (GH-156915) (#156960) gh-156896: Stop scrubbing tkinter submodules upon idlelib.run import (#156915) Instead, invoke the scrubbing within run.main, which is called after the import when starting the IDLE user process. To manually test that scrub_tkinter_submodules is called when proper, start (or restart) Shell, enter `import tkinter; dir(tkinter), and check that that font, messagebox, ttk, and the dialog modules are missing. It is obvious from the code that the function is not otherwise called. To test anyway, continue with `import tkinter.ttk; import idlelib.run; tkinter.ttk` and check for proper output. (cherry picked from commit e50d233) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
…mport (python#156915) Instead, invoke the scrubbing within run.main, which is called after the import when starting the IDLE user process. To manually test that scrub_tkinter_submodules is called when proper, start (or restart) Shell, enter `import tkinter; dir(tkinter), and check that that font, messagebox, ttk, and the dialog modules are missing. It is obvious from the code that the function is not otherwise called. To test anyway, continue with `import tkinter.ttk; import idlelib.run; tkinter.ttk` and check for proper output.
…import (GH-156915) (#156958) gh-156896: Stop scrubbing tkinter submodules upon idlelib.run import (#156915) Instead, invoke the scrubbing within run.main, which is called after the import when starting the IDLE user process. To manually test that scrub_tkinter_submodules is called when proper, start (or restart) Shell, enter `import tkinter; dir(tkinter), and check that that font, messagebox, ttk, and the dialog modules are missing. It is obvious from the code that the function is not otherwise called. To test anyway, continue with `import tkinter.ttk; import idlelib.run; tkinter.ttk` and check for proper output. (cherry picked from commit e50d233) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Instead, invoke the scrubbing within run.main, which is called after the import when starting the IDLE user process.
To manually test that scrub_tkinter_submodules is called when proper, start (or restart) Shell, enter `import tkinter; dir(tkinter), and check that that font, messagebox, ttk, and the dialog modules are missing.
It is obvious from the code that the function is not otherwise called. To test anyway, continue with import tkinter.ttk; import idlelib.run; tkinter.ttk and check for proper output.