FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-156939: Fix struct.pack('0p', bytes) (GH-157071) by miss-islington · Pull Request #157131 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.13] gh-156939: Fix struct.pack('0p', bytes) (GH-157071) #157131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Sep 7, 2026
Conversation 0 Commits 1 Checks 39 Files changed
Merged

[3.13] gh-156939: Fix struct.pack('0p', bytes) (GH-157071) #157131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .c  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
gh-156939: Fix struct.pack('0p', bytes) (GH-157071) 
If the Pascal string is empty (size=0), do not write the size prefix.
Previously, a NUL byte was written outsize the buffer (buffer
overflow). In practice, the write remains into allocated memory
and is silently ignored: no memory is corrupted.
(cherry picked from commit 23525c9)

Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
vstinner authored and miss-islington committed Sep 7, 2026
commit 277733e5a992f6918e3db38870f05d833dfe066f
4 changes: 3 additions & 1 deletion Modules/_struct.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2020,7 +2020,9 @@ s_pack_internal(PyStructObject *soself, PyObject *const *args, int offset,
memcpy(res + 1, p, n);
if (n > 255)
n = 255;
*res = Py_SAFE_DOWNCAST(n, Py_ssize_t, unsigned char);
if (n > 0) {
*res = Py_SAFE_DOWNCAST(n, Py_ssize_t, unsigned char);
}
} else {
if (e->pack(state, res, v, e) < 0) {
if (PyLong_Check(v) && PyErr_ExceptionMatches(PyExc_OverflowError))
Expand Down
Loading
Back | FazBrowse Home | New Git URL