FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-157157: Make test_taskgroup_cancel_keeps_outer_cancellation deterministic by iamsharduld · Pull Request #157158 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-157157: Make test_taskgroup_cancel_keeps_outer_cancellation deterministic #157158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 2 commits into from
Sep 11, 2026
Conversation 4 Commits 2 Checks 54 Files changed
Merged

gh-157157: Make test_taskgroup_cancel_keeps_outer_cancellation deterministic #157158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86ee308
gh-157157: Make test_taskgroup_cancel_keeps_outer_cancellation determ…
iamsharduld Sep 8, 2026
c4778ee
Remove the NEWS entry
iamsharduld Sep 8, 2026
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
11 changes: 9 additions & 2 deletions Lib/test/test_asyncio/test_taskgroups.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1200,11 +1200,17 @@ async def child(tg):

async def test_taskgroup_cancel_keeps_outer_cancellation(self):
# gh-155433: any cancellation from outside the group must propagate.
cancelling = asyncio.Event()
release = asyncio.Event()

async def child():
try:
await asyncio.sleep(10)
finally:
await asyncio.sleep(0.1)
# The group is cancelling: it has cancelled its parent task
# and is waiting for this task to finish.
cancelling.set()
await release.wait()

async def body():
async with asyncio.TaskGroup() as tg:
Expand All @@ -1213,8 +1219,9 @@ async def body():
tg.cancel()

task = asyncio.create_task(body())
await asyncio.sleep(0.01)
await cancelling.wait()
task.cancel('message')
release.set()
with self.assertRaises(asyncio.CancelledError) as cm:
await task
self.assertEqual('message', cm.exception.args[0])
Expand Down
Loading
Back | FazBrowse Home | New Git URL