Repository navigation
[3.15] gh-156924: Try reifying lazy imports in ForwarRef.evaluate() (GH-156940) - #157224
Merged
hugovk merged 1 commit intoSep 10, 2026
Merged
hugovk merged 1 commit into
hugovk merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ythonGH-156940) (cherry picked from commit 52ffffe) Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
JelleZijlstra
approved these changes
Sep 9, 2026
Copy link
Copy Markdown
Member
|
@encukou would you mind reviewing this backport so it can go into 3.15 final? |
Sorry, something went wrong.
encukou
approved these changes
Sep 10, 2026
encukou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'm not too familiar with this part of the codebase, but, it makes sense to me and I couldn't find an issue.
Not sure it's the kind of emergency fix to go in a RC; that's @hugovk's call.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This is okay for the final. |
Sorry, something went wrong.
Kronuz
pushed a commit
to Kronuz/cpython
that referenced
this pull request
Oct 5, 2026
…ate()` (pythonGH-156940) (python#157224) Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com> (cherry picked from commit 013c4ae)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 52ffffe)
Co-authored-by: Victorien 65306057+Viicos@users.noreply.github.com
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
Co-authored-by: Petr Viktorin encukou@gmail.com
Co-authored-by: Bartosz Sławecki bartosz@ilikepython.com