FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-157265: tarfile: Honor None result of filter for link fallbacks (GH-157266) by miss-islington · Pull Request #157308 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.13] gh-157265: tarfile: Honor None result of filter for link fallbacks (GH-157266) #157308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 3 commits into from
Sep 21, 2026
Conversation 2 Commits 3 Checks 43 Files changed
Merged

[3.13] gh-157265: tarfile: Honor None result of filter for link fallbacks (GH-157266) #157308

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05f187c
gh-157265: tarfile: Honor None result of filter for link fallbacks (G…
encukou Sep 11, 2026
f93473e
gh-157265: Adjust test for Windows (GH-157334)
encukou Sep 11, 2026
ddc31a3
Merge branch '3.13' into backport-fb2f0bb-3.13
encukou Sep 15, 2026
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Next Next commit
gh-157265: Adjust test for Windows (GH-157334) 
gh-157266: Adjust test for Windows

On Windows (no symlinks, no hardlinks), the behaviour is
the same as without the fix in GH-157266:
- a/t/dummy is extracted
- b/ is extracted
- c/ is *not* created (the target, a/t, is not in the archive)
- c/escape: c/ is created; escape is skipped (target,
   c/../../link_here, is not in archive)
- c is not recreated as a directory
- boom is not created (target is c/escape, which falls back to
  ..\..\link_here, which does not exist in archive)
  • Loading branch information
encukou committed Sep 14, 2026
commit f93473e550cc2e75f3ebc5cc890ca1af318efe36
10 changes: 5 additions & 5 deletions Lib/test/test_tarfile.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -4418,15 +4418,15 @@ def test_sneaky_hardlink_fallback(self):
for filter in 'tar', 'fully_trusted':
with self.subTest(filter), self.check_context(arc.open(), filter):
if not os_helper.can_symlink():
if filter == 'tar':
if filter == 'fully_trusted' or sys.platform == "win32":
self.expect_file("a/t/dummy")
self.expect_file("b/")
self.expect_file("c/")
else:
self.expect_exception(
tarfile.LinkFallbackError,
"link 'boom' would be extracted as a copy of "
+ "'c/escape', which was rejected")
else:
self.expect_file("a/t/dummy")
self.expect_file("b/")
self.expect_file("c/")
else:
self.expect_file("a/t/dummy")
self.expect_file("b/")
Expand Down
Loading
Back | FazBrowse Home | New Git URL