Repository navigation
[3.15] gh-155526: Don't check errno in abs(complex) (GH-155527) - #157341
Merged
hugovk merged 1 commit intoSep 15, 2026
Merged
hugovk merged 1 commit into
hugovk merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…55527) abs(complex) no longer raises OverflowError if errno was set to ERANGE by some library call but abs() doesn't overflow. (cherry picked from commit e5d4fa2) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: hpkfft.com <paul@hpkfft.com>
vstinner
approved these changes
Sep 13, 2026
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @skirpichev and @hugovk, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker 340cfbaf679c1230fd438042d764b6922b483242 3.13 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-157555 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-157558 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
hugovk
pushed a commit
that referenced
this pull request
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
abs(complex) no longer raises OverflowError if errno was set to ERANGE by some library call but abs() doesn't overflow.
(cherry picked from commit e5d4fa2)