Repository navigation
gh-157242: Add _PyBytes_IsMutable() assertion - #157371
Merged
vstinner merged 3 commits intoSep 12, 2026
Merged
vstinner merged 3 commits into
vstinner merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Elaborate mutability in _PyBytes_Resize() and PyBytesWriter documentation. Check _PyBytes_IsMutable() in functions which require a mutable bytes object like PyBytesWriter_Resize().
Copy link
Copy Markdown
Member
Author
|
I also wanted to add these assertions: assert(_PyObject_IsUniquelyReferenced(v));
assert(get_ob_shash((PyBytesObject*)v) == -1);
But IMO these checks are too strict and can fail in use cases which work currently. The PyBytesWriter has this warning:
But there is no check at runtime, even in debug mode. |
Sorry, something went wrong.
Comment thread
Doc/c-api/bytes.rst
Outdated
Copy link
Copy Markdown
Documentation build overview2 files changed ± c-api/bytes.html ± whatsnew/changelog.html |
Sorry, something went wrong.
vstinner
enabled auto-merge (squash)
September 12, 2026 19:48
johnslavik
pushed a commit
to johnslavik/cpython
that referenced
this pull request
Sep 14, 2026
Elaborate on mutability in _PyBytes_Resize() and PyBytesWriter documentation. Check _PyBytes_IsMutable() in functions which require a mutable bytes object like PyBytesWriter_Resize().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elaborate mutability in _PyBytes_Resize() and PyBytesWriter documentation.
Check _PyBytes_IsMutable() in functions which require a mutable bytes object like PyBytesWriter_Resize().