Repository navigation
[3.14] gh-156713: Use the filesystem encoding in nturl2path (GH-156717) - #157424
Merged
serhiy-storchaka merged 1 commit intoSep 13, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…156717) urllib.request.pathname2url() and url2pathname() use the filesystem encoding and error handler since pythongh-85168, but nturl2path, which implements them on Windows before 3.14, was left unchanged. Paths containing surrogate characters raised UnicodeEncodeError. (cherry picked from commit 01599e2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
Member
|
@serhiy-storchaka ARM64 Raspbian 3.14 failed: ======================================================================
FAIL: test_pathname2url (test.test_nturl2path.NTURL2PathTest.test_pathname2url)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/stan/buildarea/3.14.stan-raspbian.nondebug/build/Lib/test/test_nturl2path.py", line 39, in test_pathname2url
self.assertEqual(fn('C:\\a\\b\xe9'), '///C:/a/b%C3%A9')
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '///C:/a/b%E9' != '///C:/a/b%C3%A9'
- ///C:/a/b%E9
? ^
+ ///C:/a/b%C3%A9
? ^^^^
======================================================================
FAIL: test_url2pathname_surrogates (test.test_nturl2path.NTURL2PathTest.test_url2pathname_surrogates)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/stan/buildarea/3.14.stan-raspbian.nondebug/build/Lib/test/test_nturl2path.py", line 123, in test_url2pathname_surrogates
self.assertEqual(nturl2path.url2pathname('///C:/' + url),
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'C:\\a\udcff')
^^^^^^^^^^^^^^
AssertionError: 'C:\\aÿ' != 'C:\\a\udcff'
- C:\aÿ
? ^
+ C:\a\udcff
? ^
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Fixed by #157461. I pushed the fix in not yet merged 3.15 backport. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urllib.request.pathname2url() and url2pathname() use the filesystem encoding
and error handler since gh-85168, but nturl2path, which implements them on
Windows before 3.14, was left unchanged. Paths containing surrogate
characters raised UnicodeEncodeError.
(cherry picked from commit 01599e2)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com