| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Remove ";" from PyABIInfo_VAR macro definition, since "PyABIInfo_VAR(abi_info);" added two ";;" which is illegal in C++03.
|
@encukou: I found this bug while enabling limited C API tests on Free Threading in test_cppext for PR gh-157493. IMO we should fix this issue in Python 3.15.0. Otherwise, developers may start writing extensions as PyABIInfo_VAR(abi_info) (without ;) which is currently accepted. I checked the documentation: PyABIInfo_VAR is always used as PyABIInfo_VAR(abi_info); (with ;). |
Sorry, something went wrong.
|
I agree. Thanks for the catch! It's @hugovk's call though. For context: IMO, for C-wielding early adopters, a NEWS entry is enough. |
Sorry, something went wrong.
|
Yes, let's have this fixed for 3.15.0, please add the NEWS entry. Should this go into main first? |
Sorry, something went wrong.
I added a NEWS entry.
I extracted the PyABIInfo_VAR macro fix from my larger PR gh-157493. The main change is under review. (I just fixed test_cppext when using clang.) |
Sorry, something went wrong.
IMO it should, to keep the change & NEWS together, and make it easier to revert if there's some unforeseen weirdness. I sent #157539. (If you think keeping this in the bigger change is better I won't object, but then add the NEWS entry there.) |
Sorry, something went wrong.
|
Thanks both, both merged! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Remove ";" from PyABIInfo_VAR macro definition, since "PyABIInfo_VAR(abi_info);" added two ";;" which is illegal in C++03.