Repository navigation
gh-93016: Fix parsing of arguments in the IDLE "Run... Customized" dialog - #157635
terryjreedy merged 1 commit into
Conversation
Sorry, something went wrong.
…ed" dialog On Windows, split the command line as the Python executable does instead of using the POSIX rules, so that backslashes are not escape characters. Display previous arguments quoted and joined, not as a Tcl list.
|
Verified bug and fix on Windows with c:\Users, \\server\share. Merging. |
Sorry, something went wrong.
|
Thanks @serhiy-storchaka for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
|
Sorry, @serhiy-storchaka and @terryjreedy, I could not cleanly backport this to 3.15 due to a conflict. cherry_picker db2d1a5a159b8e7862648750f80cde0b30d02f47 3.15 |
Sorry, something went wrong.
|
GH-158049 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
|
GH-158050 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
…zed" dialog (GH-157635) (#158050) gh-93016: Fix parsing of arguments in the IDLE "Run... Customized" dialog (GH-157635) On Windows, split the command line as the Python executable does instead of using the POSIX rules, so that backslashes are not escape characters. Display previous arguments quoted and joined, not as a Tcl list. (cherry picked from commit db2d1a5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…zed" dialog (GH-157635) (#158049) gh-93016: Fix parsing of arguments in the IDLE "Run... Customized" dialog (GH-157635) On Windows, split the command line as the Python executable does instead of using the POSIX rules, so that backslashes are not escape characters. Display previous arguments quoted and joined, not as a Tcl list. (cherry picked from commit db2d1a5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
Thanks @serhiy-storchaka for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
|
GH-159083 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
…zed" dialog (GH-157635) (GH-159083) On Windows, split the command line as the Python executable does instead of using the POSIX rules, so that backslashes are not escape characters. Display previous arguments quoted and joined, not as a Tcl list. (cherry picked from commit db2d1a5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
CustomRun.cli_args_ok() used shlex.split() with POSIX rules on every platform, so on Windows backslashes were treated as escape characters (c:\Users became c:Users) and single quotes as quotes, unlike python.exe, whose sys.argv follows the C runtime rules. And the previous arguments were passed as a list to the entry StringVar, which displayed them as a Tcl list ({c:users}).
On Windows, the command line is now split with the same rules as the C runtime uses (backslashes are literal unless they precede a double quote; \" is a literal quote; "" inside a quoted part is a literal quote). The new util._split_windows() was checked against the actual sys.argv of python.exe on Windows for a set of tricky inputs, and it round-trips subprocess.list2cmdline(), which is now used to display the previous arguments (shlex.join() on other platforms).
🤖 Generated with Claude Code