Repository navigation
gh-142217: Add tests on the deprecated _Py_Identifier C API - #157638
Merged
vstinner merged 3 commits intoSep 17, 2026
Merged
vstinner merged 3 commits into
vstinner merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Replace PyDict_GetItemWithError() with PyDict_GetItemRef() and remove outdated comment in Modules/_pickle.c.
Copy link
Copy Markdown
Member
Author
|
While these macros and functions are deprecated, we still have to support them until October 2030 (Python 3.19.0 final release). So I prefer to test this (deprecated and undocumented) C API. |
Sorry, something went wrong.
vstinner
added a commit
that referenced
this pull request
Oct 16, 2026
* gh-142217: Add tests on the deprecated _Py_Identifier C API (#157638) (cherry picked from commit 21403af) * gh-156939: Add tests on the PyUnicode C API (#157798) Add tests on functions: * PyUnicode_CHECK_INTERNED() * PyUnicode_Check() * PyUnicode_CheckExact() * PyUnicode_Equal() * PyUnicode_GET_LENGTH() * PyUnicode_IS_ASCII() * PyUnicode_IS_COMPACT() * PyUnicode_IS_COMPACT_ASCII() * PyUnicode_KIND() * PyUnicode_MAX_CHAR_VALUE() * PyUnicode_READ() * PyUnicode_READ_CHAR() * PyUnicode_WRITE() Changes: * Add test on PyUnicode_FromOrdinal(0). * Require _testcapi module in test_capi.test_unicode. Since _testcapi is specific to CPython, remove @support.cpython_only. (cherry picked from commit e8f6448)
vstinner
added a commit
that referenced
this pull request
Oct 16, 2026
[3.15] gh-156939: Add tests on the PyUnicode C API (#159533) * gh-142217: Add tests on the deprecated _Py_Identifier C API (#157638) (cherry picked from commit 21403af) * gh-156939: Add tests on the PyUnicode C API (#157798) Add tests on functions: * PyUnicode_CHECK_INTERNED() * PyUnicode_Check() * PyUnicode_CheckExact() * PyUnicode_Equal() * PyUnicode_GET_LENGTH() * PyUnicode_IS_ASCII() * PyUnicode_IS_COMPACT() * PyUnicode_IS_COMPACT_ASCII() * PyUnicode_KIND() * PyUnicode_MAX_CHAR_VALUE() * PyUnicode_READ() * PyUnicode_READ_CHAR() * PyUnicode_WRITE() Changes: * Add test on PyUnicode_FromOrdinal(0). * Require _testcapi module in test_capi.test_unicode. Since _testcapi is specific to CPython, remove @support.cpython_only. (cherry picked from commit e8f6448) (cherry picked from commit bcbe9bc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace PyDict_GetItemWithError() with PyDict_GetItemRef() and remove outdated comment in Modules/_pickle.c.