Repository navigation
gh-156388: Docs: clarify DocumentType identifiers - #157646
Open
Neiland85 wants to merge 2 commits into
Open
Neiland85 wants to merge 2 commits into
Neiland85 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
16 of 19 tasks
Copy link
Copy Markdown
Contributor
Author
|
Thanks for confirming this point in the issue discussion. I’ve submitted #157646 to document that mapping explicitly. For parsed XML documents, the combinations correspond as follows:
I also noted in the PR that createDocumentType() does not validate the identifiers, so programmatically created DocumentType objects may have other combinations. I’ll leave the PR open for maintainer review and follow any requested changes. |
Sorry, something went wrong.
Neiland85
force-pushed
the
docs-xml-dom-156388
branch
from
bc6be00 to
fbdb382
Compare
September 19, 2026 03:53
Copy link
Copy Markdown
Documentation build overview33 files changed · + 1 added · ± 32 modified + Added ± Modified |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #156388
Clarify the documented relationship between DocumentType.publicId and systemId for parsed XML documents, including PUBLIC and SYSTEM declarations, and note that createDocumentType() does not validate identifier combinations for programmatically created objects.
This covers only the publicId/systemId mapping. Other remaining items in #156388 are out of scope.