Repository navigation
gh-157649: Restore safe C++ refcount macro temporaries - #157718
Closed
sankalpsthakur wants to merge 2 commits into
Closed
sankalpsthakur wants to merge 2 commits into
sankalpsthakur wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Use the existing memcpy fallback for C++ and test array items, references, single evaluation and concrete object pointers. AI assistance: ChatGPT assisted with implementation and validation. The regression and fallback approach follow the issue discussion.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
vstinner
reviewed
Sep 18, 2026
Comment thread
Lib/test/test_cppext/extension.cpp
Outdated
Comment thread
Lib/test/test_cppext/extension.cpp
sankalpsthakur
force-pushed
the
fix/gh157649-cpp-refcount-lvalues
branch
from
05dd746 to
f7d703b
Compare
September 18, 2026 15:42
cursor
Bot
force-pushed
the
fix/gh157649-cpp-refcount-lvalues
branch
from
968de3e to
c2d26be
Compare
September 18, 2026 16:11
…ment Address Victor Stinner review: mention the tested macros in the source comment above test_refcount_lvalues().
cursor
Bot
force-pushed
the
fix/gh157649-cpp-refcount-lvalues
branch
from
c2d26be to
a66a922
Compare
September 18, 2026 16:12
Copy link
Copy Markdown
Member
|
The AI is not just an assistance.It is writjng everything. I am not considering this a human PR enough and this does exceed the realm of acceptable use. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
That is not true but your call |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157649.
Use the existing memcpy() implementations of Py_CLEAR, Py_SETREF and Py_XSETREF for C++, as suggested in the issue discussion. decltype() can bind their temporary to an array element or reference, so overwriting the destination decrements the wrong pointer. The C paths are unchanged.
The C++ regression exercises all three macros with array elements, references, NULL destinations, single evaluation and concrete object pointers. Py_CLEAR() also runs in the limited-API build. Thanks to Lucas Colley for the report/bisection and Victor Stinner for the fallback approach.
Validation
Original before/after run, Ubuntu x86-64, GCC/g++ 13.3, debug CPython 3.16 built from 8542958:
That fork run covered only the extension suites. Subsequently, upstream Tests run 35367131812 completed successfully on head a66a922; lint and label checks also pass. The follow-up commit changes only the requested source comment. No NumPy rebuild is claimed.
AI assistance: ChatGPT assisted with implementation and validation.