Repository navigation
gh-157763: Fix ctypes.util.test() on Windows - #157770
lazerg wants to merge 1 commit into
Conversation
Sorry, something went wrong.
ZeroIntensity
left a comment
There was a problem hiding this comment.
This function is untested, hardly used, and doesn't seem particularly useful to anyone. I think we should just soft-deprecate it rather than take on maintenance.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
|
Closing in favor of #157776. Removing the function is better than fixing the call in it. |
Sorry, something went wrong.
The Windows branch of ctypes.util.test() calls cdll.load("msvcrt"), but LibraryLoader has no load method, so the call ends up in __getattr__ and raises AttributeError: load.
Use LoadLibrary, which is what every other branch of the same function already does.