FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-157875: Fix a reference leak when rewinding JIT traces by Wulian233 · Pull Request #157888 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-157875: Fix a reference leak when rewinding JIT traces - #157888

Open
Wulian233 wants to merge 3 commits into
python:mainfrom
Wulian233:trace
ConversationCommits (3)ChecksFiles changed
Open

gh-157875: Fix a reference leak when rewinding JIT traces#157888
Wulian233 wants to merge 3 commits into
python:mainfrom
Wulian233:trace

Conversation

Wulian233 commented Sep 21, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Sep 21, 2026
Open
cocolato mentioned this pull request Sep 21, 2026
Closed
cocolato reviewed Sep 21, 2026
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py Outdated

Wulian233 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

gently ping @markshannon

johng reviewed Oct 2, 2026
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py
"""), PYTHON_JIT="1")
self.assertEqual(result[0].rc, 0, result)

def test_157875_rewound_trace_reference_leak(self):

johng Oct 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should this test assert that the rewinding happened? Or would that make the test too brittle?

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-09-21-16-00-00.gh-issue-157875.7Qn4Jp.rst
@@ -0,0 +1,2 @@
Fix a reference leak in the JIT when a trace is rewound after encountering
unsupported bytecode.

johng Oct 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

maybe just say when tracing is rewound? I think this get's triggered for standard supported JIT traces hit natural endings such as jumps

Wulian233 Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It seems too detailed. We can ask others?👀

Comment thread Python/optimizer.c
_PyUOpInstruction *curr = uop_buffer_last(trace);
while (curr->opcode != _SET_IP && uop_buffer_length(trace) > 2) {
if (_PyUop_Flags[curr->opcode] & HAS_RECORDS_VALUE_FLAG) {
Py_XDECREF((PyObject *)(uintptr_t)curr->operand0);

johng Oct 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

we now have a very similar pattern three times in this file, maybe worth seeing if it's worth to make it a common operation

Wulian233 Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think it would be better to focus on the bug fix scope of this PR. However, currently the JIT has been suspended and only bug fixes are accepted

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cocolato cocolato left review comments
markshannon Awaiting requested review from markshannon markshannon is a code owner
Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
+1 more reviewer
johng johng left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL