FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-157788: Fix `test_long_task_name_is_truncated` by not hardcoding main task name by hugovk · Pull Request #157911 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-157788: Fix test_long_task_name_is_truncated by not hardcoding main task name - #157911

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:3.16-fix-test_long_task_name_is_truncated
Sep 22, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-157788: Fix test_long_task_name_is_truncated by not hardcoding main task name#157911
hugovk merged 1 commit into
python:mainfrom
hugovk:3.16-fix-test_long_task_name_is_truncated

Conversation

hugovk commented Sep 21, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Fixes #157790 (comment).

The refleaks buildbots run with -R 3:3 so does 3 warmups and 3 runs, so the test is run 6 times in the same process. The first task name is "Task-1" for the first run, and "Task-4" for the second, and so on.

bedevere-app Bot added the tests Tests in the Lib/test dir label Sep 21, 2026
hugovk added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Sep 21, 2026

bedevere-bot commented Sep 21, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 04d98a4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157911%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Sep 21, 2026
hugovk added skip news 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Sep 21, 2026

bedevere-bot commented Sep 21, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 04d98a4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157911%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Sep 21, 2026
hugovk marked this pull request as ready for review September 21, 2026 14:12

hugovk commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

Passing so far on buildbots:

hugovk added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes and removed needs backport to 3.13 only security fixes labels Sep 21, 2026
encukou approved these changes Sep 22, 2026
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! It passes, I'll merge to unblock the buildbots.

I wonder if adding a name argument to run would be useful. For tests only it's definitely not worth it.

hugovk merged commit 6eedb1a into python:main Sep 22, 2026
87 checks passed
hugovk deleted the 3.16-fix-test_long_task_name_is_truncated branch September 22, 2026 10:28

miss-islington-app Bot commented Sep 22, 2026

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Sep 22, 2026

Copy link
Copy Markdown

GH-157941 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Sep 22, 2026

bedevere-app Bot commented Sep 22, 2026

Copy link
Copy Markdown

GH-157942 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 22, 2026
hugovk added a commit that referenced this pull request Sep 22, 2026
[3.15] gh-157788: Fix test_long_task_name_is_truncated by not hardc…
2b3b252 
…oding main task name (GH-157911) (#157941)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Sep 22, 2026
[3.14] gh-157788: Fix test_long_task_name_is_truncated by not hardc…
c77e98a 
…oding main task name (GH-157911) (#157942)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL