FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v… by vasiliyk · Pull Request #157912 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v… - #157912

Merged
encukou merged 1 commit into
python:mainfrom
vasiliyk:gh-119048-shutil
Sep 22, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-119048: Use shutil._use_fd_functions in test_rmtree_uses_safe_fd_v…#157912
encukou merged 1 commit into
python:mainfrom
vasiliyk:gh-119048-shutil

Conversation

vasiliyk commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The test recomputed the fd-functions flag with os.listdir in os.supports_fd, but shutil switched its own check to os.scandir, so the copy in the test went stale.

Use shutil._use_fd_functions directly instead of duplicating as suggested by @encukou in the issue.

vasiliyk requested a review from giampaolo as a code owner September 21, 2026 13:45
bedevere-app Bot added the tests Tests in the Lib/test dir label Sep 21, 2026

bedevere-app Bot commented Sep 21, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Sep 21, 2026
Closed

bedevere-app Bot commented Sep 21, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

vasiliyk force-pushed the gh-119048-shutil branch 2 times, most recently from 64d168b to ddd72aa Compare September 21, 2026 17:21

bedevere-app Bot commented Sep 21, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

encukou merged commit 9777e8a into python:main Sep 22, 2026
63 of 100 checks passed

encukou commented Sep 22, 2026

Copy link
Copy Markdown
Member

Thank you for the fix.
For the future, please avoid force-pushing in CPython PRs. It usually makes review harder.

aisk mentioned this pull request Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland left review comments
giampaolo Awaiting requested review from giampaolo giampaolo is a code owner
encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL