| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Added DNM label to ensure opportunity for discussion so it's not just Stan and I pushing this through in case someone is truly relying on this behavior. |
Sorry, something went wrong.
There was a problem hiding this comment.
+1
Sorry, something went wrong.
There was a problem hiding this comment.
Backport all the way too?
Sorry, something went wrong.
IIUC it should be uncontroversial to remove this workflow from all non-main branches regardless of whether it is ultimately removed from main, as it should have no effect in non-default branches. In theory :) |
Sorry, something went wrong.
|
Yeah this one is annoying. We are already editing the description when a PR is linked (and this causes races sometimes) but I always have edit races with this workflow! |
Sorry, something went wrong.
Sorry, something went wrong.
|
It was added to maintain the status quo of the issue templates we used before issue forms. @StanFromIreland Let's try that, please can you set up a demo in your fork? |
Sorry, something went wrong.
|
Sure, you can test in https://github.com/StanFromIreland/cpython-ci-testing/issues. |
Sorry, something went wrong.
There was a problem hiding this comment.
From the demo: StanFromIreland/cpython-ci-testing#7
This can't maintain the status quo of big obvious title, but it'll do.
Sorry, something went wrong.
|
As I see no objections here, and the title has been preserved (albeit as a H3), I'm going merge this now. |
Sorry, something went wrong.
Sorry, something went wrong.
|
We only need the file deletion and not the template changes, so let's do it as part of #158399. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This was added after the switch to issue templates (see #108033 (comment)), however, it's not ideal. It runs after the issue is opened, and edits the existing issue. This means users can run into conflicts if they edit their issue, it pollutes the edit history, and adds information that is already is available in the form of a label (although this is debatable, as the label is quite a bit smaller).
I propose we remove it, what do people think?