FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-156026: Document that the 'tar' filter does not bound link targets by drengir1 · Pull Request #158038 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-156026: Document that the 'tar' filter does not bound link targets #158038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drengir1 wants to merge 1 commit into from
Conversation 4 Commits 1 Checks 35 Files changed
Closed

gh-156026: Document that the 'tar' filter does not bound link targets #158038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .rst  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
16 changes: 15 additions & 1 deletion Doc/library/tarfile.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,8 @@ can be:

* the string ``'tar'``: Honor most *tar*-specific features (i.e. features of
UNIX-like filesystems), but block features that are very likely to be
surprising or malicious. See :func:`tar_filter` for details.
surprising or malicious. This does not include limiting the targets of
symbolic links. See :func:`tar_filter` for details.

* the string ``'data'``: Ignore or block most features specific to UNIX-like
filesystems. Intended for extracting cross-platform data archives.
Expand Down Expand Up @@ -1124,6 +1125,19 @@ reused in custom filters:

Return the modified ``TarInfo`` member.

.. warning::

This filter does not limit where a link member *points*.
:attr:`TarInfo.linkname` is not checked, so a symbolic link whose target
is an absolute path, or a relative path that climbs outside the
destination, is extracted as given.
The rule above constrains where each member is *written*; it does not
constrain where a link resolves to.

Only :func:`data_filter` refuses such members, raising
:class:`~tarfile.AbsoluteLinkError` or
:class:`~tarfile.LinkOutsideDestinationError`.

.. versionchanged:: next

Filenames containing ``..`` components are now normalized.
Expand Down
Loading
Back | FazBrowse Home | New Git URL