FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix docstring typo in subprocess.py by xmatthias · Pull Request #15812 · python/cpython · GitHub

/ cpython Public

Fix docstring typo in subprocess.py - #15812

Merged
gpshead merged 1 commit into
python:masterfrom
xmatthias:subprocess_typo
Sep 10, 2019
Merged

Fix docstring typo in subprocess.py#15812
gpshead merged 1 commit into
python:masterfrom
xmatthias:subprocess_typo

Conversation

Copy link
Copy Markdown
Contributor

Fix docstring typo in subprocess.py

it should be will, not wil, otherwise this sentence does not make sense.

xmatthias requested a review from gpshead as a code owner September 9, 2019 18:22

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks for catching this.

xmatthias commented Sep 9, 2019
edited
Loading

Copy link
Copy Markdown
Contributor Author

give me a bit - i'm moving through CLA

edit: signed it twice now (once before registering and once after - and my github username is attached to the profile).
I hope it'll just need some time to show up on the heroku app.

Copy link
Copy Markdown
Contributor

Thanks @xmatthias for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
(cherry picked from commit 182e1d1)

Co-authored-by: Matthias <xmatthias@outlook.com>

Copy link
Copy Markdown

GH-15854 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
(cherry picked from commit 182e1d1)

Co-authored-by: Matthias <xmatthias@outlook.com>

Copy link
Copy Markdown

GH-15855 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 10, 2019
(cherry picked from commit 182e1d1)

Co-authored-by: Matthias <xmatthias@outlook.com>
miss-islington added a commit that referenced this pull request Sep 10, 2019
(cherry picked from commit 182e1d1)

Co-authored-by: Matthias <xmatthias@outlook.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL