WIP: bpo-1615158 : POSIX capabilities support (In a separate module) - #15815
Closed
nanjekyejoannah wants to merge 2 commits into
Closed
WIP: bpo-1615158 : POSIX capabilities support (In a separate module)#15815nanjekyejoannah wants to merge 2 commits into
nanjekyejoannah wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
eryksun
reviewed
Sep 9, 2019
Comment thread
Modules/posixcapmodule.c
| #define PY_SSIZE_T_CLEAN | ||
|
|
||
| #include "Python.h" | ||
| #ifdef MS_WINDOWS |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
AFAICT, this module has nothing to do with Windows, in which case there's no reason to include windows.h or winreparse.h.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Noted. This was a result of a copy paste I think. I am revising this patch. Like I said it is still draft. Reviewing it now will waste anyone's time.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Could you please add [WIP] to the title, just after the "bpo-#:" part? This makes it significantly easier to spot. |
Sorry, something went wrong.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP. Dont bother reviewing now.
Co-Author : Matt Kern
https://bugs.python.org/issue1615158