Repository navigation
gh-156939: Fix Modules/_testcapi/bytes.c: remove double Py_DECREF - #158400
Merged
vstinner merged 1 commit intoSep 29, 2026
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Remove a spurious Py_DECREF(writer_type) in _PyTestCapi_Init_Bytes() that over-decremented the reference after it was already released. Also fix writer_discard method flags (METH_VARARGS -> METH_NOARGS), a typo, and PEP 7 spacing in for-loop initializers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @vstinner, I could not cleanly backport this to 3.15 due to a conflict. cherry_picker 90d40027f75cb096ac9abf85f3fb6a2a13b21824 3.15 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Ah, the discard() test method was not backported to 3.15 branch yet. I will backport it later with other PyBytesWriter changes. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a spurious Py_DECREF(writer_type) in _PyTestCapi_Init_Bytes() that over-decremented the reference after it was already released. Also fix writer_discard method flags (METH_VARARGS -> METH_NOARGS), a typo, and PEP 7 spacing in for-loop initializers.