Repository navigation
gh-158402: Clear error if PyImport_GetModule raises in lazy import - #158403
Closed
encukou wants to merge 2 commits into
Closed
encukou wants to merge 2 commits into
encukou wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
encukou
requested review from
DinoV,
Yhg1s,
markshannon and
pablogsal
as code owners
September 29, 2026 11:20
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope this is the right fix: I'm assuming lazy import cannot fail (it can't be put in a try block), and
@pablogsal's change in #157714 suggests another possible assumption: that lazy import cannot run user code. That's not the case now, though.
cc @brittanyrey