Repository navigation
gh-156939: Fix two bugs in PyBytesWriter - #158404
vstinner merged 1 commit into
Conversation
Sorry, something went wrong.
Fix PyBytesWriter_Format() error handling: restore the writer to its previous state on error. Add an unit test injecting MemoryError. Fix PyBytesWriter_FinishWithSize() to return an empty bytearray when use_bytearray is set and size is 0, instead of always returning an empty bytes object. Fix test_capi.test_bytes: always check writer finish result type, to make sure that _PyBytesWriter_CreateByteArray() always create bytearray objects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The "Android aarch64" job failed with a download error: Command "curl -Lf --retry 5 --retry-all-errors -o /Users/runner/work/cpython/cpython/cross-build/downloads/xz-5.4.6-1-aarch64-linux-android.tar.gz https://github.com/beeware/cpython-android-source-deps/releases/download/xz-5.4.6-1/xz-5.4.6-1-aarch64-linux-android.tar.gz" returned exit status 56. I restarted the job. |
Sorry, something went wrong.
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
|
Sorry, @vstinner, I could not cleanly backport this to 3.15 due to a conflict. cherry_picker 24ea85a4c2998b36cc4c83ff0505678d178b49d1 3.15 |
Sorry, something went wrong.
|
GH-158409 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
* gh-156939: Fix two bugs in PyBytesWriter (#158404) Fix PyBytesWriter_Format() error handling: restore the writer to its previous state on error. Add an unit test injecting MemoryError. Fix PyBytesWriter_FinishWithSize() to return an empty bytearray when use_bytearray is set and size is 0, instead of always returning an empty bytes object. Fix test_capi.test_bytes: always check writer finish result type, to make sure that _PyBytesWriter_CreateByteArray() always create bytearray objects. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit 24ea85a)
Fix PyBytesWriter_Format() error handling: restore the writer to its previous state on error. Add an unit test injecting MemoryError.
Fix PyBytesWriter_FinishWithSize() to return an empty bytearray when use_bytearray is set and size is 0, instead of always returning an empty bytes object.
Fix test_capi.test_bytes: always check writer finish result type, to make sure that _PyBytesWriter_CreateByteArray() always create bytearray objects.