Repository navigation
gh-158413: Release shutdown lock while joining broken workers - #158444
Open
GruffElixir wants to merge 1 commit into
Open
GruffElixir wants to merge 1 commit into
GruffElixir wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-158413.
When a worker exits unexpectedly, the manager now marks the pool broken under _shutdown_lock but releases the lock before cleaning up and joining the remaining workers. This keeps submit() and shutdown(wait=False) from waiting behind a worker that ignores termination.
Added a regression test that holds a simulated worker join open and verifies the shutdown lock stays available, plus a Library NEWS entry.
Tests: focused broken-pool cleanup test and three existing spawn-based worker-failure tests.