Repository navigation
Enable missing TestJsonEncoding tests - #158668
Open
hugovk wants to merge 1 commit into
Open
hugovk wants to merge 1 commit into
hugovk wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
eendebakpt
approved these changes
Oct 3, 2026
Copy link
Copy Markdown
Member
|
Hi. I also discovered this issue and I wrote PR #158937 to fix it. @StanFromIreland told me that @hugovk already wrote this fix. My PR moves @reap_threads on each test method rather than removing it, and it also adds a check to @reap_threads to detect misusage of the decorator (fails if the argument is a class). Would you mind to review my change? #158937 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The threading_helper.reap_threads decorator is intended for test functions, not classes, and applying it to the class means it didn't run:
https://github.com/python/cpython/actions/runs/37135589260/job/111239394429#step:19:2263
Removing it allows the tests to run:
https://github.com/hugovk/cpython/actions/runs/37135650674/job/111251480717#step:19:391
This wasn't visible before #158620 (except for occasional re-runs).
Originally added in #119438, cc @eendebakpt.