bpo-36876: Add a tool that identifies unsupported global C variables. - #15877

Merged

ericsnowcurrently merged 118 commits into

python:masterfrom

ericsnowcurrently:globals-checker

Sep 11, 2019

Commits on Sep 11, 2019

Bootstrap the "c-statics" script under the test suite.
ericsnowcurrently
committed
9cdba01
Stub out the "check" and "show" commands.
ericsnowcurrently
committed
cfdf57f
Add a README.
ericsnowcurrently
committed
716b13d
Fix a filename.
ericsnowcurrently
committed
ff1b447
Run the full check as part of the test suite.
ericsnowcurrently
committed
7e7d52d
Frame out the functional tests.
ericsnowcurrently
committed
74d03d4
Ignore the argparse output in tests.
ericsnowcurrently
committed
34d2c7c
Move relevant tests to test_cg/.
ericsnowcurrently
committed
e8e2227
Add StaticVar.
ericsnowcurrently
committed
69541bf
Add a fake find.statics().
ericsnowcurrently
committed
cab1fc8
Add show.basic().
ericsnowcurrently
committed
4bf5299
Implement cmd_show().
ericsnowcurrently
committed
c74360f
Add a note about the normalized vartype format.
ericsnowcurrently
committed
b94833d
Do not run tests for find.statics() yet.
ericsnowcurrently
committed
6fecaad
Implement cmd_check().
ericsnowcurrently
committed
8a53e69
Add scan.iter_statics().
ericsnowcurrently
committed
98d3737
Add supported.is_supported().
ericsnowcurrently
committed
28e0f99
Add find.statics().
ericsnowcurrently
committed
1d6696c
Sort the output.
ericsnowcurrently
committed
7e09aa4
Implement scan.iter_statics().
ericsnowcurrently
committed
265098d
Add cg.files.iter_files().
ericsnowcurrently
committed
ac70e2c
Add cg.info.Symbol.
ericsnowcurrently
committed
587907c
Properly handle local variables.
ericsnowcurrently
committed
6ff136f
Implement cg.parse.iter_variables().
ericsnowcurrently
committed
9faeba9
Start the implementation for iter_statements().
ericsnowcurrently
committed
ae5c872
Deal with comments.
ericsnowcurrently
committed
0687e09
Handle functions in iter_global_declarations().
ericsnowcurrently
committed
a50aa32
Implement basic variable support.
ericsnowcurrently
committed
044a1f4
Implement parse_func().
ericsnowcurrently
committed
c7833c1
Implement parse_var().
ericsnowcurrently
committed
2c164cd
Ignore files in Include/cpython.
ericsnowcurrently
committed
84cd77e
Rename the c-globals tool directory to be more generic.
ericsnowcurrently
committed
dc471a3
Add imports_under_tool() CM.
ericsnowcurrently
committed
a9c27c5
Move the code under Tools (and the tests under test_tools).
ericsnowcurrently
committed
60dee31
Split up the files properly.
ericsnowcurrently
committed
c0f1313
Factor out c_parser/{source,util}.py and c_symbols/local.py.
ericsnowcurrently
committed
5410467
Factor out preprocessor.py.
ericsnowcurrently
committed
caac1a9
Factor out _NTBase.
ericsnowcurrently
committed
928cc96
Add the wrapped_arg_combos() testing helper.
ericsnowcurrently
committed
baf2bce
Add preprocessor.iter_lines().
ericsnowcurrently
committed
57ec889
Remove line continuations and comments in preprocessor.iter_lines().
ericsnowcurrently
committed
400b388
Fix minor formatting.
ericsnowcurrently
committed
13eb7b1
Handle the "ignored" and "known" args to statics().
ericsnowcurrently
committed
182e3f9
Factor out statics_from_symbols().
ericsnowcurrently
committed
ec88a4c
StaticVar -> Variable.
ericsnowcurrently
committed
a269b15
Add statics_from_declarations().
ericsnowcurrently
committed
842ef7c
Track the per-variable preprocessor conditions.
ericsnowcurrently
committed
853768a
Add util.Slot (a descriptor).
ericsnowcurrently
committed
5f1b8b9
Add util.classonly (a la classmethod).
ericsnowcurrently
committed
b850c05
Add util._NOT_SET.
ericsnowcurrently
committed
cde5b32
Add _NTBase.from_raw().
ericsnowcurrently
committed
11377dd
Add info.ID.
ericsnowcurrently
committed
acbedc7
Use ID in Symbol.
ericsnowcurrently
committed
08310bf
Use ID in Variable.
ericsnowcurrently
committed
1d5e9bf
Add a note about a "conditions" slot for info.ID.
ericsnowcurrently
committed
0c56fd9
Require Variable to have filename set.
ericsnowcurrently
committed
9563689
"???" means "unknown".
ericsnowcurrently
committed
7ad89b2
Make find_local_symbol() a "public" argument.
ericsnowcurrently
committed
2b2bc66
Add info.ID.islocal.
ericsnowcurrently
committed
1316a3b
Factor out c_analyzer_common package.
ericsnowcurrently
committed
4bdd9a6
Move info.Symbol under c_symbols.
ericsnowcurrently
committed
5d52d9f
Do not allow Variable.id to have UNKNOWN in it.
ericsnowcurrently
committed
d7d0d91
Cache Variable.isstatic.
ericsnowcurrently
committed
f662b63
Move known_from_file() to common/known.py.
ericsnowcurrently
committed
e963103
Add look_up_known_symbol() and symbols_to_variables().
ericsnowcurrently
committed
2cf6d6a
Move files.py under common.
ericsnowcurrently
committed
3d80342
known_from_file() -> known.from_file().
ericsnowcurrently
committed
d58c7c4
Make dirnames optional.
ericsnowcurrently
committed
2fca1e7
Drop c_statics.scan.
ericsnowcurrently
committed
1e34a1a
Implement known.from_file() and ignored_from_file().
ericsnowcurrently
committed
3f2e4f6
Fix REPO_ROOT.
ericsnowcurrently
committed
3e1657a
Various minor fixes to get to stable.
ericsnowcurrently
committed
a2779b4
Add util.read_tsv() and util.write_tsv().
ericsnowcurrently
committed
89b887a
Treat "-" in .tsv file as None.
ericsnowcurrently
committed
89a02c3
Fix the statics_from_binary() tests.
ericsnowcurrently
committed
697ab59
Add code to generate known.tsv.
ericsnowcurrently
committed
66a69c4
Fix a typo in get_resolver().
ericsnowcurrently
committed
411aadd
Fix a typo in _find_statics().
ericsnowcurrently
committed
3bfb345
Implement is_supported() (first pass).
ericsnowcurrently
committed
9d731e7
Show the vartype in the basic output format.
ericsnowcurrently
committed
021be3c
Use the underlying ID for the hash of Symbol and Variable.
ericsnowcurrently
committed
f620135
Move constants out of c_statics.__init__.
ericsnowcurrently
committed
e7a029d
Fix a typo.
ericsnowcurrently
committed
b99c9f2
Clean up iter_files().
ericsnowcurrently
committed
3aeb32d
Fix typos.
ericsnowcurrently
committed
8a97e50
Minor fix to find/resolve.
ericsnowcurrently
committed
51d5a19
Include ID in error message.
ericsnowcurrently
committed
19b9f97
Add some "naive" parsing tools.
ericsnowcurrently
committed
a9c68c5
Expand the capability of the "known" generator.
ericsnowcurrently
committed
2af6781
Update the "known" variables with generated values.
ericsnowcurrently
committed
aa8495a
Consider all known variables as static.
ericsnowcurrently
committed
921a465
Distinguish "static" vars in output.
ericsnowcurrently
committed
48b2460
Special-case variables named "id".
ericsnowcurrently
committed
c0a631b
Fix a test.
ericsnowcurrently
committed
3989a69
Print totals.
ericsnowcurrently
committed
8118454
Fail if we couldn't find any of the symbols.
ericsnowcurrently
committed
cae5e3a
Factor out _check_results().
ericsnowcurrently
committed
87ebe87
Fill in gaps in known.tsv.
ericsnowcurrently
committed
91e4fb1
Mark _Py_IDENTIFIER() as unsupported.
ericsnowcurrently
committed
21c4175
Keep "static" in output.
ericsnowcurrently
committed
a245849
Fix a typo in __main__.py.
ericsnowcurrently
committed
1437d56
Honor provided dirnames.
ericsnowcurrently
committed
7feea9d
Fix tests.
ericsnowcurrently
committed
ae23801
Deal with default dirnames properly.
ericsnowcurrently
committed
26aaccb
Supporting hiding objects in output.
ericsnowcurrently
committed
4aaad5f
Recognize more object types.
ericsnowcurrently
committed
3d36cfc
Ignore known non-statics.
ericsnowcurrently
committed
b7420d5
Always support "static const" (non-object) variables.
ericsnowcurrently
committed
da151a7
"statics" -> "globals".
ericsnowcurrently
committed
6470eb1
Maybe limit the variables in known.tsv.
ericsnowcurrently
committed
1233cf9
Generate the ignored.tsv file.
ericsnowcurrently
committed
fc6c97e
Ignore variables with benign races.
ericsnowcurrently
committed
6f8a223
Mark more variables as PyObject.
ericsnowcurrently
committed
6c1db44
Consider private, non-static globals.
ericsnowcurrently
committed
5888d48
Update ignored global variables.
ericsnowcurrently
committed
cdeb1d9
Fix whitespace.
ericsnowcurrently
committed
b5dd31b

Commits on Sep 12, 2019

Skip the check where "nm" isn't available.
ericsnowcurrently
committed
569c57e
Ignore REPL-related variables.
ericsnowcurrently
committed
7b0745f

bpo-36876: Add a tool that identifies unsupported global C variables. by ericsnowcurrently · Pull Request #15877 · python/cpython · GitHub

Uh oh!

Uh oh!

bpo-36876: Add a tool that identifies unsupported global C variables. - #15877

bpo-36876: Add a tool that identifies unsupported global C variables.#15877ericsnowcurrently merged 118 commits intopython:masterpython/cpython:masterfrom ericsnowcurrently:globals-checkerericsnowcurrently/cpython:globals-checkerCopy head branch name to clipboard

Commits

Commits on Sep 11, 2019

Commits on Sep 12, 2019

bpo-36876: Add a tool that identifies unsupported global C variables.#15877
ericsnowcurrently merged 118 commits into
python:masterfrom
ericsnowcurrently:globals-checker