Repository navigation
gh-158574: Stabilize TLBC cache refresh tests - #158801
Merged
pablogsal merged 2 commits intoOct 5, 2026
Merged
pablogsal merged 2 commits into
pablogsal merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
pablogsal
enabled auto-merge (squash)
October 5, 2026 01:02
Copy link
Copy Markdown
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @pablogsal, I could not cleanly backport this to 3.14 due to a conflict. Please backport manually with cherry_picker, see the devguide for more information. cherry_picker 0e75a0555731b9d7713d473e65b991f77316838c 3.14 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-158817 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-158818 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
pablogsal
pushed a commit
that referenced
this pull request
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158574.
The TLBC cache refresh tests can sample a worker while it is returning from go.wait() and entering leaf(). Reading the thread state and stack at different times can produce an inconsistent frame snapshot, causing invalid memory reads or incorrect line numbers.
Have each worker notify a native SimpleQueue when it reaches its waiting function, then block in a native lock. The sampler waits for those notifications before reading the stacks. Both tests retain the same unwinder across phases and check the expected frames and source lines.