Repository navigation
gh-158824: Fix __getattr__ blocking reification of lazy imports - #158825
Merged
encukou merged 4 commits intoOct 8, 2026
Merged
encukou merged 4 commits into
encukou merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
When a module attribute was a lazy import placeholder, module attribute lookup called the module's __getattr__ before resolving it. This was needed while lazy from-imports published placeholders on the source module. That no longer happens, so the check only affected the module's own lazy imports: a catch-all __getattr__ hid them, unlike eager imports. Resolve the placeholder directly.
brittanyrey
requested review from
DinoV,
Yhg1s,
ericsnowcurrently and
pablogsal
as code owners
October 5, 2026 03:23
pablogsal
approved these changes
Oct 5, 2026
pablogsal
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Comment thread
Misc/NEWS.d/next/Core_and_Builtins/2026-10-05-03-25-30.gh-issue-158824.h-hJj7.rst
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Updated the news entry per request |
Sorry, something went wrong.
encukou
approved these changes
Oct 8, 2026
Copy link
Copy Markdown
|
Thanks @brittanyrey for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-159022 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
encukou
pushed a commit
that referenced
this pull request
Oct 12, 2026
…rts (GH-158825) (GH-159022) When a module attribute was a lazy import placeholder, module attribute lookup called the module's __getattr__ before resolving it. This was needed while lazy from-imports published placeholders on the source module. That no longer happens, so the check only affected the module's own lazy imports: a catch-all __getattr__ hid them, unlike eager imports. Resolve the placeholder directly. (cherry picked from commit 56f9837) Co-authored-by: Brittany Reynoso <breynoso@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module attribute lookup called the module's getattr before resolving a lazy import placeholder.
That was the fix for gh-144957, needed while lazy from imports put placeholders into the source module. gh-150052 removed that, so the check now only shadows a module's own lazy imports.
This fixes that issue and adds a new load bearing test.