This is wrong, it'll incorrectly show up as green. It should be made optional in the job that checks all actions pass, that way we're aware if it fails.

We'll have to split it out of the matrix IIRC, I can make such a PR if that's easier?

We'll have to split it out of the matrix IIRC, I can make such a PR if that's easier?

I don't see how to do you that. If you know how to do it, please go ahead and create a PR!

I created issue #158868 to track this bug.

Oh, MSan ran but this time, the test suite passed: https://github.com/python/cpython/actions/runs/37328259158/job/111824581661?pr=158865.

This is wrong, it'll incorrectly show up as green. It should be made optional in the job that checks all actions pass, that way we're aware if it fails.

It is wrong but for a slightly different reason. Kinda. This change is also a no-op — it adds a matrix factor that is not wired anywhere. I told Victor to add a continue-on-error on the specific matrix job but didn't give specific instructions so that's on me.

It would not show up as green, if wired, though. It would show up as a red status in the PR widget and among the jobs in the matrix. But alls-green would see it as green. So it would not be hidden fully.

For these, I'd recommend additionally marking the job name as [xfail] or something.

I suggest instead to fix the issue: #158872

#158872 fixed the MSan issue instead.