FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-158646: Fix flake in test_shutdown_corrupted_ssl_sends_close_notify by deadlovelll · Pull Request #158877 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-158646: Fix flake in test_shutdown_corrupted_ssl_sends_close_notify #158877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deadlovelll wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 0 Commits 1 Checks 47 Files changed
Open

gh-158646: Fix flake in test_shutdown_corrupted_ssl_sends_close_notify #158877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
6 changes: 4 additions & 2 deletions Lib/test/test_asyncio/functional.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,14 @@ def recv_all(self, n):

def start_tls(self, ssl_context, *,
server_side=False,
server_hostname=None):
server_hostname=None,
suppress_ragged_eofs=True):

ssl_sock = ssl_context.wrap_socket(
self.__sock, server_side=server_side,
server_hostname=server_hostname,
do_handshake_on_connect=False)
do_handshake_on_connect=False,
suppress_ragged_eofs=suppress_ragged_eofs)

try:
ssl_sock.do_handshake()
Expand Down
7 changes: 4 additions & 3 deletions Lib/test/test_asyncio/test_sslproto.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -954,14 +954,15 @@ def server(sock):
try:
sock.start_tls(
sslctx,
server_side=True)
server_side=True,
suppress_ragged_eofs=False)
sock.sendall(b'A\n')
sock.recv_all(1)
orig_sock.send(b'please corrupt the SSL connection')
# the client now closes the connection; although its
# TLS shutdown fails on the corrupted record, it must
# still send close_notify, completing our unwrap()
sock.unwrap()
# still send close_notify
self.assertEqual(sock.recv(1), b'')
except ssl.SSLError as exc:
server_err = exc
finally:
Expand Down
Loading
Back | FazBrowse Home | New Git URL