FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make Argument Clinic exit with an error if a warning was emitted by StanFromIreland · Pull Request #158930 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Make Argument Clinic exit with an error if a warning was emitted - #158930

Open
StanFromIreland wants to merge 2 commits into
python:mainfrom
StanFromIreland:clinic-fail-on-warning
ConversationCommits (2)ChecksFiles changed
Open

Make Argument Clinic exit with an error if a warning was emitted#158930
StanFromIreland wants to merge 2 commits into
python:mainfrom
StanFromIreland:clinic-fail-on-warning

Conversation

StanFromIreland commented Oct 6, 2026

Copy link
Copy Markdown
Member

This would have avoided #158892.

cmaloney approved these changes Oct 6, 2026
View reviewed changes

cmaloney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems like maybe this should be a -Werror type option in the CI?

Would be nice to have some form of tests (run clinic on a text snippet which produces a warning and check the exit code) to help make sure this doesn't regress.

StanFromIreland commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

Seems like maybe this should be a -Werror type option in the CI?

I thought about this, however, if it's failing in the CI I think users would prefer for it to also fail, to catch such things before pushing.

Would be nice to have some form of tests

Sure, added.

cmaloney approved these changes Oct 6, 2026
View reviewed changes

cmaloney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the test, looks good to me. Makes sense we can change default behavior and having only one behavior is nice when possible

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cmaloney cmaloney approved these changes
serhiy-storchaka Awaiting requested review from serhiy-storchaka
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting core review skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL