FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-158886: Add INCREF/DECREF macros to stable_abi.toml by vstinner · Pull Request #158941 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-158886: Add INCREF/DECREF macros to stable_abi.toml - #158941

Open
vstinner wants to merge 6 commits into
python:mainfrom
vstinner:stable_ref_macros
ConversationCommits (6)ChecksFiles changed
Open

gh-158886: Add INCREF/DECREF macros to stable_abi.toml#158941
vstinner wants to merge 6 commits into
python:mainfrom
vstinner:stable_ref_macros

Conversation

vstinner commented Oct 6, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Oct 6, 2026
Open

read-the-docs-community Bot commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34984221 | 📁 Comparing 953d7e2 against main (1818fba)

  🔍 Preview build  

5 files changed · ± 5 modified

± Modified

vstinner mentioned this pull request Oct 6, 2026
Draft
vstinner marked this pull request as ready for review October 6, 2026 22:18

vstinner commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

@encukou: Ok, here is a small PR only adding 7 macros.

maurycy reviewed Oct 6, 2026
View reviewed changes
Comment thread Misc/stable_abi.toml
encukou mentioned this pull request Oct 7, 2026
Merged

encukou commented Oct 7, 2026

Copy link
Copy Markdown
Member

Thanks for getting to this. I spent some time thinking about this but kept getting lost in rabbit-holes. Let's do this step first :)

There's a few changes I'd like to make here. I sent them as vstinner#20.
If you'd like me to push directly here and let you review, let me know.

Changes for python#158941 (#20)
803f7ad 
* distinguish between 'const' and 'macro' in stable_abi.dat

The file now has the 'kind' from the toml, not the ReST role.

* Fix kind of PY_VECTORCALL_ARGUMENTS_OFFSET

* Regenerate stable_abi.dat

* Make it explicit that macros aren't part of the ABI

* Move is_static_inline_function (per-item data) to the TOML file

* Appease linter rule, despite PEP 8

vstinner commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

There's a few changes I'd like to make here. I sent them as vstinner#20.

Thanks, I merged your PR.

If you'd like me to push directly here and let you review, let me know.

If I can chose, I prefer that you create a PR on my branch, as you did.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou Awaiting requested review from encukou encukou is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
hugovk Awaiting requested review from hugovk hugovk is a code owner
StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland is a code owner
1 more reviewer
maurycy maurycy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL