Repository navigation
gh-158903: Avoid AttributeError in BaseEventLoop.__del__ and close() during premature teardown - #158954
Closed
JohnnyWilson16 wants to merge 1 commit into
Closed
gh-158903: Avoid AttributeError in BaseEventLoop.__del__ and close() during premature teardown#158954JohnnyWilson16 wants to merge 1 commit into
JohnnyWilson16 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
JohnnyWilson16
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
October 7, 2026 06:54
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
JohnnyWilson16
force-pushed
the
fix-gh-158903-eventloop-del-attributeerror
branch
from
3729a70 to
1776568
Compare
October 7, 2026 07:05
…ose() during premature teardown
JohnnyWilson16
force-pushed
the
fix-gh-158903-eventloop-del-attributeerror
branch
from
1776568 to
48c92ce
Compare
October 7, 2026 07:51
Copy link
Copy Markdown
Member
|
This adds un-necessary defensive guards for a very rare event. And I don't think it's necessary to have it. I'm closing it because it's premature to do so and I'll Kumar decide on whether he wants to accept the issue. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interrupted event loop initialization (e.g. keyboard interrupt or signal received before _make_self_pipe() or proactor setup completes) leaves attributes like _ssock, _csock, _selector, _proactor, and _signal_handlers uninitialized or partially assigned. When garbage collected, BaseEventLoop.__del__ calls self.close() -> _close_self_pipe(), unconditionally dereferencing self._ssock.fileno() and raising an AttributeError via sys.unraisablehook.
This patch guards internal attribute dereferences across BaseSelectorEventLoop, _UnixSelectorEventLoop, and BaseProactorEventLoop during close() and _close_self_pipe(), ensuring partially initialized loops tear down cleanly.
Fixes #158903.