Repository navigation
gh-159137: Copy and subtract the GC reference counts in one walk - #159163
Closed
pablogsal wants to merge 4 commits into
Closed
pablogsal wants to merge 4 commits into
pablogsal wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Closing this PR. I’ve learned that @brandtbucher's mentee has been working on something very close to this for a while and was planning to open source it once a few things cleared up. Rather than duplicate that effort, I’d prefer to focus on their work and help get it upstream, so I’ll be following up on that instead :) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collector walks the generation once in update_refs() to copy every reference count into the GC header, and again in subtract_refs() to subtract the references between the collected objects. In a full collection every tracked object is in the list, so the second walk needs nothing from the first, and this does both in one walk. An object that is decremented before the walk reaches it still holds its _gc_prev pointer, and the walk recovers the decrements from the difference with the pointer it knows was there.
Benchmarks
CPU time spent in the collector, taken in gc.callbacks. Six runs per executable in baseline/candidate/candidate/baseline order; medians of the runs taken while the machine was quiet.