FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.14] gh-157649: Merge test_cppext into test_cext (#158176) (#159264) by vstinner · Pull Request #159276 · python/cpython · GitHub

Repository navigation

[3.14] gh-157649: Merge test_cppext into test_cext (#158176) (#159264) - #159276

Merged
vstinner merged 2 commits into
python:3.14from
vstinner:merge_test_cppext14
Oct 13, 2026
Merged

vstinner merged 2 commits into
python:3.14from
vstinner:merge_test_cppext14

Conversation

vstinner commented Oct 12, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  • test_cext now uses a single virtual environment for all tests. It makes the test way faster since creating a virtual environment is quite slow.
  • Add Py_TARGET_ABI3T test on C++.
  • Move macro tests from module exec function to test_macros().
  • Call Py_BEGIN_CRITICAL_SECTION() on a fresh dictionary object, rather than on the module.
  • Rename some environment variables to always use "CPYTHON_TEST_" prefix.
  • Replace support.MS_WINDOWS with MSVC to be more explicit.
  • Move macro tests to test_macros().
  • On macOS, use C++11 by default.

(cherry picked from commit b71989d) (cherry picked from commit 364db5d)

…) (python#159264)

* test_cext now uses a single virtual environment for all tests.
  It makes the test way faster since creating a virtual environment
  is quite slow.
* Add Py_TARGET_ABI3T test on C++.
* Move macro tests from module exec function to test_macros().
* Call Py_BEGIN_CRITICAL_SECTION() on a fresh dictionary object,
  rather than on the module.
* Rename some environment variables to always use "CPYTHON_TEST_"
  prefix.
* Replace support.MS_WINDOWS with MSVC to be more explicit.
* Move macro tests to test_macros().
* On macOS, use C++11 by default.

(cherry picked from commit b71989d)
(cherry picked from commit 364db5d)

Copy link
Copy Markdown
Member Author

!buildbot s390x Fedora Stable PR

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 3453e44 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F159276%2Fmerge

The command will test the builders whose names match following regular expression: s390x Fedora Stable PR

The builders matched are:

  • s390x Fedora Stable PR

vstinner enabled auto-merge (squash) October 13, 2026 06:44
vstinner merged commit 1d0f58b into python:3.14 Oct 13, 2026
47 checks passed
vstinner deleted the merge_test_cppext14 branch October 13, 2026 06:47
def test_build_c11(self):
self.check_build('_test_cext_c11', std='c11')

def test_build_limited(self):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hm, IIUC, this is no longer skipped for free threading and thus fails e.g. AMD64 CentOS9 NoGIL 3.14: https://buildbot.python.org/?#/builders/1733/builds/2119/steps/5/logs/stdio:

/home/buildbot/buildarea/3.14.itamaro-centos-aws.nogil/build/Include/Python.h:52:4:
error: #error "The limited API is not currently supported in the free-threaded build"

I wonder why it passed in CI and on so many other no-gil bots?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I wrote #159371 to skip limited C API tests on Free Threading.

I forgot to test this case locally, and GitHub Action jobs skip test_cext.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

GitHub Action jobs skip test_cext

Ah, yes, due to --fast-ci. But why is it then not listed under "tests skipped"?

And why did other no-gil bots pass that use --slow-ci?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL