FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-159320: Enable stack size detection on Android by Yhg1s · Pull Request #159321 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-159320: Enable stack size detection on Android - #159321

Merged
Yhg1s merged 3 commits into
python:mainfrom
Yhg1s:android-stack-check
Oct 14, 2026
ConversationCommits (3)ChecksFiles changed
Merged

gh-159320: Enable stack size detection on Android#159321
Yhg1s merged 3 commits into
python:mainfrom
Yhg1s:android-stack-check

Conversation

Yhg1s commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Extend the use of pthread_getattr_np in stack size detection from any glibc linux to any glibc or android linux, instead of assuming a minimum size of 1.2Mb (which we override in tests).

Yhg1s requested a review from markshannon as a code owner October 13, 2026 14:41
bedevere-app Bot mentioned this pull request Oct 13, 2026
Open
Yhg1s requested a review from mhsmith October 13, 2026 14:43
Yhg1s requested review from Eclips4 and tomasr8 as code owners October 13, 2026 21:16
Yhg1s mentioned this pull request Oct 13, 2026
Open

Yhg1s commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

#159376 is a more general fix for the same issue (instead of just Android it enables stack protection on all Linux libc's)

mhsmith reviewed Oct 14, 2026
View reviewed changes

mhsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but I guess it would be better to merge #159376 instead.

Comment thread Python/ceval.c Outdated
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-10-13-16-38-00.gh-issue-159320._Yhg1s.rst Outdated
Apply batched suggestions from code review
d3516fe 
Co-authored-by: Malcolm Smith <smith@chaquo.com>

Yhg1s commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

LGTM, but I guess it would be better to merge #159376 instead.

Actually, after some consideration I think we should merge this and backport it, then merge the other one for 3.16+ only.

Yhg1s enabled auto-merge (squash) October 14, 2026 11:37
Yhg1s added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 14, 2026
Yhg1s disabled auto-merge October 14, 2026 12:10
Yhg1s merged commit 8ff41c2 into python:main Oct 14, 2026
65 checks passed

miss-islington-app Bot commented Oct 14, 2026

Copy link
Copy Markdown

Thanks @Yhg1s for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Oct 14, 2026

Copy link
Copy Markdown

GH-159409 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 14, 2026

bedevere-app Bot commented Oct 14, 2026

Copy link
Copy Markdown

GH-159410 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 14, 2026
Yhg1s added a commit that referenced this pull request Oct 14, 2026
[3.14] gh-159320: Enable stack size detection on Android (GH-159321) (#…
a11d4cd 
…159410)

gh-159320: Enable stack size detection on Android (GH-159321)

Extend the use of pthread_getattr_np in stack size detection from any glibc linux to any glibc *or* android linux. Update tests for android's new recursion limit.
(cherry picked from commit 8ff41c2)

Co-authored-by: T. Wouters <thomas@python.org>
Co-authored-by: Malcolm Smith <smith@chaquo.com>
Yhg1s added a commit that referenced this pull request Oct 14, 2026
[3.15] gh-159320: Enable stack size detection on Android (GH-159321) (#…
b6d63f1 
…159409)

gh-159320: Enable stack size detection on Android (GH-159321)

Extend the use of pthread_getattr_np in stack size detection from any glibc linux to any glibc *or* android linux. Update tests for android's new recursion limit.
(cherry picked from commit 8ff41c2)

Co-authored-by: T. Wouters <thomas@python.org>
Co-authored-by: Malcolm Smith <smith@chaquo.com>
serhiy-storchaka mentioned this pull request Oct 20, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mhsmith mhsmith left review comments
markshannon Awaiting requested review from markshannon markshannon is a code owner
Eclips4 Awaiting requested review from Eclips4 Eclips4 is a code owner
tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL