Repository navigation
gh-159517: Do not use ::tk::unsupported::MacWindowStyle in IDLE on Tk 9.1 - #159527
Merged
serhiy-storchaka merged 1 commit intoOct 17, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… on Tk 9.1 Tk 9.1 no longer provides this command. Use "wm attributes -stylemask docmodal" instead, as Tk itself does for its balloon window. The calls were silently ignored, so the completion list and the call tip could grab the focus on macOS.
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-159624 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-159625 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 17, 2026
…E on Tk 9.1 (GH-159527) (GH-159625) Tk 9.1 no longer provides this command. Use "wm attributes -stylemask docmodal" instead, as Tk itself does for its balloon window. The calls were silently ignored, so the completion list and the call tip could grab the focus on macOS. (cherry picked from commit e5ef47e) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 17, 2026
…E on Tk 9.1 (GH-159527) (GH-159624) Tk 9.1 no longer provides this command. Use "wm attributes -stylemask docmodal" instead, as Tk itself does for its balloon window. The calls were silently ignored, so the completion list and the call tip could grab the focus on macOS. (cherry picked from commit e5ef47e) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tk 9.1 no longer provides ::tk::unsupported::MacWindowStyle. The calls in IDLE were wrapped in try/except TclError, so they are now silently ignored, and the completion list and the call tip can grab the focus on macOS again.
Use wm attributes -stylemask docmodal instead, as Tk itself does for its balloon window in library/systray.tcl.
Not tested on macOS.