Repository navigation
gh-159437: Count garbage during weakref cleanup - #159598
Draft
mfalco-oai wants to merge 3 commits into
Draft
mfalco-oai wants to merge 3 commits into
mfalco-oai wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
pablogsal
reviewed
Oct 17, 2026
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The counting change seems independent of the callback refactor. clear_weakrefs() already walks the final collectable list without running Python, so returning its size doesn't need the new callback helper or list selection. Let's keep this change seperate if that refactor gets reworked.
Sorry, something went wrong.
mfalco-oai
force-pushed
the
mfalco-oai/gh-159437-gc-count
branch
from
768f2d6 to
934dc3b
Compare
October 19, 2026 22:23
mfalco-oai
force-pushed
the
mfalco-oai/gh-159437-gc-count
branch
from
934dc3b to
70bc796
Compare
October 21, 2026 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this optimization the GIL collector counts collectable objects during late weakref cleanup. This removes the separate gc_list_size() walk over the same list.
Performance
Before is #159587 (ff1acf0a); after is this PR at 70bc7962. Both builds use -falign-functions=64.
gc_collect_self_lists collects 1,000,000 one-element lists that refer to themselves.
Benchmarks: python/pyperformance#496