Repository navigation
gh-159690: Fix TimedRotatingFileHandler stopping rollovers after a failed or skipped rollover - #159691
Closed
lazerg wants to merge 2 commits into
Closed
gh-159690: Fix TimedRotatingFileHandler stopping rollovers after a failed or skipped rollover#159691lazerg wants to merge 2 commits into
lazerg wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…r a failed or skipped rollover
Copy link
Copy Markdown
Member
|
I'm going to close this because the OP may have wanted to open a PR themselves. Please don't let any running agent snipe issues to create PRs automatically. Or at least, ask on the issue if the OP wants to make a PR. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doRollover() only updated rolloverAt on its last line, so an early return (backup name already exists, as happens at DST changes) or an exception after the rename left it in the past. Every later emit() then hit the same early return and the handler never rolled over again. Now rolloverAt is computed as soon as the backup name is known, so only that one rollover is affected.